20241213-fips-check-refactor-assoc-arrays #8291
Merged
+123
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douzzer
force-pushed
the
20241213-fips-check-refactor-assoc-arrays
branch
from
635e47a to
901785a
Compare
* change default WOLFSSL_REPO to the canonical upstream. * refactor tag calculation without bash associative arrays, for backward compat. * add support for fetching FIPS tags/branches into a persistent fips repo if one is found at ../fips. * use --shared in git clones where applicable. * always check out the master FIPS branch, for its tooling, and always make sure it's up to date with $FIPS_REPO. * after each fetch for a previously unknown tag, explicitly associate the tag with the FETCH_HEAD.
douzzer
force-pushed
the
20241213-fips-check-refactor-assoc-arrays
branch
from
901785a to
7c5451c
Compare
kaleb-himes
requested changes
Dec 17, 2024
There was a problem hiding this comment.
I am not sure what is causing this but on an aarch64 M1 macOS using this new checkout script results in the build believing I am on an intel mac system, something is affecting auto-tools ability to detect the correct environment:
245 --- new-XXX-fips-test/Makefile→→2024-12-17 07:35:46
246 +++ old-XXX-fips-test/Makefile→→→2024-12-17 07:44:54
247 @@ -633,9 +633,9 @@
248 NORMAL_UNINSTALL = :
249 PRE_UNINSTALL = :
250 POST_UNINSTALL = :
251 -build_triplet = x86_64-apple-darwin23.4.0 <-------- New solution thinks it should be an intel mac???
252 -host_triplet = x86_64-apple-darwin23.4.0
253 -target_triplet = x86_64-apple-darwin23.4.0
254 +build_triplet = aarch64-apple-darwin23.4.0 <------- Old solution gets it right
255 +host_triplet = aarch64-apple-darwin23.4.0
256 +target_triplet = aarch64-apple-darwin23.4.0
kaleb-himes
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fips-check.sh fixes + enhancements:
tested with
wolfssl-multi-test.sh ... check-source-text check-shell-scripts, and with/home/douzzer/src/bash-3.2.57/bash ./fips-check.sh fips-readyand/home/douzzer/src/bash-3.2.57/bash ./fips-check.sh linuxv5